Skip to content

chore(kafka/instance): use new API to replace history API and improve acceptance test #8366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 26, 2025
Merged

chore(kafka/instance): use new API to replace history API and improve acceptance test #8366

merged 2 commits into from
Nov 26, 2025

Conversation

@wuzhuanhong
Copy link
Contributor

@wuzhuanhong wuzhuanhong commented Nov 20, 2025

What this PR does / why we need it:

  1. Use new API to replace history API and improve acceptance test.
  2. Fixed an error when updating storage_space.
    • After updating broker_num, an error occurred when the storage_space in the script was the same as the current storage_space.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

PR Checklist

  • Tests added/passed.
 ./scripts/coverage.sh -o kafka -f TestAccKafkaInstance_
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/kafka" -v -coverprofile="./huaweicloud/services/acceptance/kafka/kafka_coverage.cov" -coverpkg="./huaweicloud/services/kafka" -run TestAccKafkaInstance_ -timeout 360m -parallel 10
=== RUN   TestAccKafkaInstance_prePaid
=== PAUSE TestAccKafkaInstance_prePaid
=== RUN   TestAccKafkaInstance_newFormat
=== PAUSE TestAccKafkaInstance_newFormat
=== RUN   TestAccKafkaInstance_publicIp
=== PAUSE TestAccKafkaInstance_publicIp
=== CONT  TestAccKafkaInstance_prePaid
=== CONT  TestAccKafkaInstance_publicIp
=== CONT  TestAccKafkaInstance_newFormat
--- PASS: TestAccKafkaInstance_prePaid (849.66s)
--- PASS: TestAccKafkaInstance_publicIp (1633.47s)
--- PASS: TestAccKafkaInstance_newFormat (2266.44s)
PASS
coverage: 18.5% of statements in ./huaweicloud/services/kafka
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/kafka     2266.514s       coverage: 18.5% of statements in ./huaweicloud/services/kafka

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong wuzhuanhong force-pushed the kafka_instance_create_api_replace branch from 64a047b to 7bc92f8 Compare November 24, 2025 07:06
@wuzhuanhong
Copy link
Contributor Author

wuzhuanhong commented Nov 24, 2025

./scripts/coverage.sh -o kafka -f TestAccKafkaInstance_
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/kafka" -v -coverprofile="./huaweicloud/services/acceptance/kafka/kafka_coverage.cov" -coverpkg="./huaweicloud/services/kafka" -run TestAccKafkaInstance_ -timeout 360m -parallel 10
=== RUN TestAccKafkaInstance_prePaid
=== PAUSE TestAccKafkaInstance_prePaid
=== RUN TestAccKafkaInstance_newFormat
=== PAUSE TestAccKafkaInstance_newFormat
=== RUN TestAccKafkaInstance_publicIp
=== PAUSE TestAccKafkaInstance_publicIp
=== CONT TestAccKafkaInstance_prePaid
=== CONT TestAccKafkaInstance_publicIp
=== CONT TestAccKafkaInstance_newFormat
--- PASS: TestAccKafkaInstance_prePaid (877.61s)
--- PASS: TestAccKafkaInstance_publicIp (1695.17s)
--- PASS: TestAccKafkaInstance_newFormat (2174.57s)
PASS
coverage: 18.3% of statements in ./huaweicloud/services/kafka
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/kafka 2174.689s coverage: 18.3% of statements in ./huaweicloud/services/kafka

@Lance52259
Copy link
Contributor

Lance52259 commented Nov 26, 2025

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 26, 2025
github-ci-robot
github-ci-robot approved these changes Nov 26, 2025
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 2fe1aee into huaweicloud:master Nov 26, 2025
10 checks passed
@wuzhuanhong wuzhuanhong deleted the kafka_instance_create_api_replace branch November 27, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugfix chore dependencies LGTM /lgtm size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wuzhuanhong @Lance52259 @github-ci-robot